Repository navigation
fix(app): show file change count before label - #58353
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The change looks sound: it only edits the English text for the review tab and file-tree tab, which now read 1 file changed / N files changed through the existing plural keys. The other locales I checked already put the count first, and the only code references to the old text are the two e2e specs this PR updates. The gui-extensions review and file tests pass and tsc -b passes there. I couldn't run the Playwright e2e tests or see the label in the app here (no browsers available), so before/after screenshots of the review tab and file tree would help.
Public API: unchanged (UI text only).
No blocking concerns.
Related: #41399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the English file change labels in the review tab and file tree from
Files Changed {count}to{count} files changed, with1 file changedfor a single file. This matches the order other locales already use.Updates the e2e assertions that match the label.
Added by the opencode bot (AI-generated).
Related: #41399