Skip to content

fix(app): show file change count before label - #58353

Merged
Brendonovich merged 1 commit into
devfrom
files-changed-label
Oct 23, 2026
Merged

Brendonovich merged 1 commit into
devfrom
files-changed-label

Conversation

@Brendonovich

@Brendonovich Brendonovich commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Changes the English file change labels in the review tab and file tree from Files Changed {count} to {count} files changed, with 1 file changed for a single file. This matches the order other locales already use.

Updates the e2e assertions that match the label.


Added by the opencode bot (AI-generated).

Related: #41399

@Brendonovich
Brendonovich requested a review from Hona as a code owner October 23, 2026 05:17

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sound: it only edits the English text for the review tab and file-tree tab, which now read 1 file changed / N files changed through the existing plural keys. The other locales I checked already put the count first, and the only code references to the old text are the two e2e specs this PR updates. The gui-extensions review and file tests pass and tsc -b passes there. I couldn't run the Playwright e2e tests or see the label in the app here (no browsers available), so before/after screenshots of the review tab and file tree would help.

Public API: unchanged (UI text only).

No blocking concerns.

Related: #41399

@Brendonovich
Brendonovich enabled auto-merge (squash) October 23, 2026 05:22
@Brendonovich
Brendonovich merged commit 09399e3 into dev Oct 23, 2026
22 checks passed
@Brendonovich
Brendonovich deleted the files-changed-label branch October 23, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant