Skip to content

fix(server): align connect route checks - #58258

Merged
jlongster merged 2 commits into
v1from
v1-align-connect-route-checks
Oct 23, 2026
Merged

jlongster merged 2 commits into
v1from
v1-align-connect-route-checks

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Issue for this PR

N/A

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Cleans up PTY, persistent PTY, and pairing connect route handling by sharing registered route definitions and removing duplicate path matching.

Downstream checks now use the route selected by the HTTP router.

How did you verify your code works?

  • Ran the server fetch and process tests
  • Ran the PTY and persistent PTY tests
  • Ran protocol and server typechecks
  • Regenerated the client
  • Ran bun run check
  • Manually verified terminal creation, connection, input, and output using the local standalone TUI

Screenshots / recordings

N/A — no UI changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@jlongster
jlongster merged commit b782d9d into v1 Oct 23, 2026
8 checks passed
@jlongster
jlongster deleted the v1-align-connect-route-checks branch October 23, 2026 16:39
hasso5703 added a commit to hasso5703/alzeo that referenced this pull request Oct 30, 2026
…oute it dispatches to

1.19.4 skipped the password check for a request whose path matched the pattern of the terminal's
connect route and carried a ticket, leaving the ticket to that route's handler. 1.19.5 skips it only
when the server dispatches the request to that handler (anomalyco/opencode#58258). It also answers a
request of the TUI's worker that fails instead of leaving it waiting, updates the package of GitLab's
provider, which this repo does not use, and otherwise removes unused code.

Checked against 1.19.4 side by side on 2026-10-30: the overflow phrases and exclusions are the same
block byte for byte, max_tokens 32,000 and 182,000 on a fake endpoint with the same headers, the same
default permissions, --yolo still read as --auto, keys still masked, sessions read both ways, the
Agent tab through a copy of the relay with its terminal and its phone layer, and a shell command
naming an aliyuncs.com host refused under --yolo and under AGENT_AUTO's permission when a fake
endpoint asked for it. On the box's FP4-Local lane both sent the same request shapes, read
hello.txt with a tool and answered 7351. The x64 digest is GitHub's, checked against the download.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant