Repository navigation
fix(core): remove missing Git worktrees from inventory - #58038
Draft
xiaoheiai4719-collab wants to merge 3 commits into
Draft
xiaoheiai4719-collab wants to merge 3 commits into
xiaoheiai4719-collab wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #57987
Type of change
What does this PR do?
Forget a saved built-in Git worktree when its directory was removed externally, and emit Updated. The active strategy must explicitly permit forgetting, so custom strategies, including an override named git, retain their existing error behavior. Files, dangling links and access errors are not treated as missing directories.
How did you verify your code works?
Linux, pinned Bun 1.4.2, CI=true and RECORD=false. Both real Git regressions fail on unchanged code. The focused suite passes 44/44; ten repetitions pass 440/440 both alone and under full-suite load. From packages/core: bun run script/test.ts test/worktree.test.ts --rerun-each 10.
Complete root lint passes with 0 errors and 1,232 repository warnings. All 34 typecheck tasks pass, run serially with no cached tasks.
Full core tests: 6,714 passed, 39 skipped, 10 failed. A clean baseline reproduces the same ten failures: patch permissions, VCS initialization, six daemon socket cases, and two configuration-discovery cases (124 passed / 10 failed across those four files). The full suite is not green. Windows was not run.
AI-assisted implementation and command execution; the publication owner has not personally rerun these checks.
Screenshots / recordings
No UI change.
Checklist