Repository navigation
fix(app): make the subagent bar say what it is and drop dead controls - #57922
kitlangton wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Looks good. I put the Child Session story through Playwright on the base and on this branch, with screenshots of each below. The bar is now one line naming the subagent, its task (the child session's title, which the subagent tool sets to the task description), the run state with elapsed time, and the way back. No model is shown. The updated subagent-bar.spec.ts passes, and the packages/app type check passes.
Public API is unchanged: this is a web app UI change only, with two new English strings.
No concerns.
85729e5 to
1e889c7
Compare
There was a problem hiding this comment.
Still looks good. My earlier review had no concerns, so there was nothing to address. The rebase onto dev only changed the model row this PR removes. The new commit lets keyboard users reach the task tooltip. In the Child Session story, focusing the task opens a tooltip with the full task and the model. component-tests/subagent-bar.spec.ts passes after the rebase, and tsc -b in packages/app passes.
Public API is unchanged: this is a web app UI change only.
No concerns.
|
Two details from my duplicate #62334 (closed in favor of this redesign) that may be worth folding in. I tested the current bar at 390×844 with
I can rebase those two details onto this branch or open a small follow-up if that helps. |
|
One practical note: this PR currently shows |






The bar shown when you view a subagent now says which subagent it is and what it is doing.
It used to be two rows with the agent, provider and model laid out like the composer's pickers, which can't be changed in a subagent session. Nothing said it was a subagent or what its task was.
❌ Before
✅ After
📊 Proof (before above, after below; fictional titles)
Running, light and dark, done, failed, interrupted:
Permission dock above, right-to-left, narrow window, long title with tooltip:
The updated component test (bar names the subagent and its task, shows no model, no composer) fails on
dev.👀 Read:
subagent-bar.tsx. Dev had since swapped the model's/for a shared slash component; that row is gone here, so the PR's version of the file replaced it. The rest is routine.Seen in real use · stills were taken before the rebase onto
dev· the rebase only touched the model row this PR removesChecks run
bun typecheckinpackages/app(after rebase ontodev): no errorscomponent-tests/subagent-bar.spec.ts(before rebase): pass; not re-run after, the browser runner was unavailable