Repository navigation
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
The rail works as described. I ran it in Chromium with seeded history: clicking a bar puts that prompt just below the header and highlights it, scrolling the wheel over the rail moves the timeline, and the newest bar is highlighted while you're at the bottom. bun run typecheck in packages/app and the two timeline e2e specs (11 tests) pass.
Public API: unchanged. The only additions are two app-only English i18n keys.
For maintainers: this is a smaller, client-only alternative to the left-edge turn navigator in #54088. That design was ported to beta, and #57737 proposes removing it there, so which design to keep is still open.
Concerns:
- The rail only covers prompts that have already loaded. In long sessions the numbering and bar positions change as older history loads (inline comment).
packages/app/AGENTS.mdasks for a before/after benchmark when timeline code changes. This PR adds work on every scroll event, so please share those numbers.
Related: #52500
| type="button" | ||
| class="group flex w-7 cursor-pointer items-center justify-end focus-visible:outline focus-visible:outline-2 focus-visible:outline-v2-border-border-strong focus-visible:outline-offset-2" | ||
| style={{ height: `${slot()}px` }} | ||
| aria-label={language.t("session.timeline.jumpToPrompt", { index: index + 1 })} |
There was a problem hiding this comment.
index + 1 counts only prompts already loaded in the timeline. Older history loads in pages as you near the top (onHistoryScroll in interaction.ts), so in a long session "Jump to prompt 1" is not the first prompt of the session. Every label and bar position also changes when a page loads. Clicking the top bar scrolls near the top, which loads older history, so the bars move under the cursor right after the click. Could the rail say that more prompts exist above, or avoid numbering that implies the full session? Alternatively, keep the clicked bar steady while history loads.
|
Hi — I use the Windows desktop client and this is exactly the navigation affordance I miss in long sessions. I noticed this branch is now ~1,640 commits behind
Before I open a PR: is the right-edge prompt rail still a direction you want? I saw the earlier turn navigator was removed (#57737) and #52500 is still waiting on design approval, so I don't want to add noise if the placement/interaction has already been decided against. I'm happy to adjust the placement (left edge), defaults, or scope. If useful, I can push the branch to a fork and link it here. |
Issue for this PR
Closes #57866
Type of change
What does this PR do?
Long sessions have no landmarks between turns. This adds a compact prompt navigator in the gutter beside the timeline scrollbar: one bar per user prompt, the prompt being read highlighted, click to jump.
The rail reuses what the timeline already has. Prompts come from the projected row list; bar positions come from the virtualizer's measurements. Clicking scrolls to
start - topOffset(), so the prompt lands below the sticky header. If the reader is pinned at the bottom, the newest prompt is current; otherwise the current prompt is the last one whose row starts at or below the fold. Wheel input over the rail is forwarded to the timeline, so scrolling past it does not dead-end.Spacing stays in a centered 240px band: the slot is
min(10, 240 / promptCount), and the bar shrinks to 1px when that gets too dense. Inactive bars are 16x2 attext-faint, the current bar is 24x2 attext-base, and hover usestext-muted. The rail is hidden below an 840px container width, where there is no gutter, and for sessions with fewer than two prompts. It also stays hidden during the cold bottom mount.I used the existing
session.timeline.*i18n namespace and left the server untouched: no new requests, endpoints, or message-index API.Related: #52500 and #54088 cover a left-edge rail built on
MessageNavwith hover previews. This is the right-edge variant from #57334 (closed as duplicate), kept deliberately small: it only knows about prompts already projected in the timeline and adds no server surface.How did you verify your code works?
bun typecheckinpackages/appbun run lint:changed(0 problems)bunx playwright test e2e/regression/timeline-geometry.spec.ts --project=chromium(9 passed)bunx playwright test e2e/regression/session-panel-scrollbar.spec.ts --project=chromium(2 passed)msg_00002_history_a_user, asserts the row is in the viewport with the highlight on the clicked bar, and asserts the rail disappears at 700px.Screenshots / recordings
prompt_navigator.webm
The rail is on the right, with the fifth prompt highlighted after clicking it:
Checklist
Added by the opencode bot (AI-generated).
Related: #52500