Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
pranam-s
force-pushed
the
fix-turn-status-announcer
branch
from
October 21, 2026 04:11
ad458d9 to
1edc137
Compare
1 task done
1 task
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Refs #57512
Type of change
What does this PR do?
A screen reader hears "Working" once and then nothing while the web UI is streaming a response. This adds one polite live region that names the phase of the running turn, so it hears "Running commands", "Searching the codebase", "Thinking", "Making edits", "Responding" and so on as the turn progresses.
The region sits beside the transcript's scroll container, outside the virtualized rows, and stays mounted for as long as the session is routed, so a screen reader announces it each time the text changes. The strings come from the
ui.sessionTurn.status.*entries inpackages/ui/src/i18n/en.ts, which are already translated in every locale; only "Responding" and "Waiting for your response" are new.The generic "Working" chip keeps the same visibility it has today. Its
role="status"is removed, along with the header indicator's, because neither could announce anything anyway: their text sits inaria-hiddenspans, and the header one put its label on arole=genericspan, which Chrome ignores. That leaves one live region for the turn status. The compaction notice inpackages/session-uikeeps its ownrole="status"and is out of scope here.This is a draft because it adds a user-visible behaviour and I would like a maintainer to sign off on the wording and on the set of phases before it lands.
How did you verify your code works?
bun run checkandbun run lint:changed origin/devpass.packages/appunit tests: 760 pass, 0 fail.On the timeline benchmark that
packages/app/AGENTS.mdasks for, the change is within noise. The projection benchmark'sreadyMsmoved by -0.10 %, +0.30 % and +0.06 % across three scenarios, with the sign flipping between two A/B rounds, against a run-to-run standard deviation of 0.25-0.65 %.missedFrameBudgetEquivalentswas 0 in 60 of 60 runs and the maximum animation frame gap was 16.8 ms in every run, before and after. The projection is rebuilt when the row structure changes, not per text delta, so the new traversal does not run on the streaming hot path.Screenshots / recordings
N/A: no visual change. The chip looks and behaves exactly as before.
Checklist