Repository navigation
fix(app): clear the traffic lights and gate sidebar toggling behind a beta setting - #56930
Open
opencode-agent[bot] wants to merge 1 commit into
Open
opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
October 19, 2026 03:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #55646 on
beta.Traffic light spacing. With the vertical tabs sidebar collapsed on macOS, the floating toggle started exactly at the 68px base width of the traffic lights. Newer macOS draws them wider (about 74px), so the toggle sat right against the green light. The collapsed toggle now lays out as if the traffic lights were the header's first control: it starts 16px past them, which is where the horizontal titlebar puts its first control. The header contents shift with it through
CollapsedSidebarToggleSpace.Beta-only setting, off by default. Sidebar toggling now sits behind Settings → Experimental → Sidebar toggle:
prod, which hides it and ignores any stored value.sidebarOpen: falsewas stored earlier. The titlebar/sidebar/collapsed toggle buttons are hidden andsidebar.toggle(mod+shift+b, View menu) is not registered.useSidebar()hook inshell/sidebar-toggle.tsxowns that gating, so shell, titlebar and toggle all read the same effectiveopen().Tests
tabs.spec.ts: the collapsed-sidebar cases now enable the setting, and a new case checks that a stored closed sidebar stays open with no toggle or shortcut while the setting is off. The new case fails on the currentbeta.tsc -bandsrc/settingsunit tests pass.Requested by: @Brendonovich (Brendan via Slack)