Repository navigation
Conversation
Port Arcadi4's permission-dock height and grid constraints from the closed, unmerged anomalyco#33563 to the current session UI. Add a long-request story and a browser regression for scrolling and reachable actions. Co-authored-by: 4rcadia <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The fix works. With the PR's new story at 390×844, the base pushes Deny / Allow always / Allow once out of view (the new test fails at toBeInViewport with "viewport ratio 0"). With this change the command area scrolls inside the dock and all three buttons stay on screen. The new test passes repeatedly, the full app component suite passes (122/122), and typecheck passes for app and session-ui.
Public API: unchanged (CSS, a story and a component test only).
No blocking concerns: the new grid-row rule only applies to the row holding the command text, so short requests keep their current layout.
Fixes #56863
This was referenced Oct 19, 2026
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49644. Also addresses #56863.
Type of change
What does this PR do?
Long permission resources can grow the dock past the viewport, hiding the approval buttons. Bound its height and let the resource grid row shrink so the existing inner scrollbar works while the footer stays visible.
This ports the layout constraints from @Arcadi4's closed, unmerged #33563 to the current session UI; the commit retains co-authorship. Adds one long-request story and one browser regression.
How did you verify your code works?
The regression fails on dev: Allow once has viewport intersection ratio 0. It passes after the fix at 390×844 and 1280×720, checks inner scrolling, and clicks Allow once.
Windows/Edge, using the repository Playwright configuration with an external channel override:
bun run typecheck: pass (app's Git symlink temporarily expanded for Windows, then restored).bun run check: lint has zero errors; full typecheck stops on missing unrelated stats-server and plugin-figma dependencies in the filtered install.AI-assisted implementation and independent code review; reviewed and tested locally.
Screenshots / recordings
Checklist
Added by the opencode bot (AI-generated).
Fixes #56863