Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #53508
Type of change
What does this PR do?
FSUtil.resolvenow calls native realpath directly on Windows. Readable workspacepaths no longer fail because the JS implementation walks an ungranted ancestor.
Actual Windows permission denials propagate; missing paths and POSIX optional-path
handling retain their behavior. Alias/cycle/containment tests and a minimal
AppContainer repro are included.
How did you verify your code works?
Core filesystem tests: 8 pass, 1 host-inapplicable denial skip. Util suite: 95 pass.
Both affected package typechecks pass. Compiled actual-helper AppContainer controls
resolve both path forms and aliases, preserve missing fallback and reject the
denied root. A separate unmodified-helper control still reproduces the failure
with released Bun 1.4.3; it sends no model prompt. The root check is blocked by this Windows checkout's unmaterialized
packages/app/src/custom-elements.d.tssymlink (Windows error 1314).The complete Beam ACP journey additionally passes on a separate 1.19.3 backport
with the Effect callback correction in Effect-TS/effect#9489.
Full ACP still needs that dependency correction; this is not a current-dev
end-to-end claim.
Screenshots / recordings
No UI change.
Checklist