Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. I ran the #56290 reproduction from source: with three locations loaded and one session created in p1, the base delivers session.created to all 3 plugin instances; with this change only p1's instance gets it. Global events still arrive. The new test fails on the base and passes here, test/plugin.test.ts passes (21/21), and packages/core type-checks.
Public API: no additions or removals, but what plugins get from ctx.event.subscribe() changes from every event in the server to events for the plugin's own location plus global (unlocated) events. Every location still gets its own instance, so each event still reaches one instance of the plugin. Only a plugin that counted on a single instance seeing other locations' events would notice. Built-in subscribers (the plan-mode reminder, the config plugins' config.updated reloads) now react only to their own location's events, which looks like an improvement.
No blocking concerns.
Related: #54140
|
Hit this with a memory plugin loaded across ~11 Locations: each completed session triggered 11 identical memory-save runs. Independently verified that binding the stream to the host Location fixes it: regression fails without the change; 57 related tests and Core typecheck pass. |
Issue for this PR
Closes #56290
Type of change
What does this PR do?
Bind plugin event streams to their host’s Location, restoring filtering lost when activation narrows the Effect context. Global broadcasts and Session-move routing remain unchanged.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Regression covers Location/workspace isolation and global events
Screenshots / recordings
no UI changes.
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.
Added by the opencode bot (AI-generated).
Related: #54140
Public API: changes plugin
ctx.event.subscribe()to deliver only the plugin's own location's events plus global ones (each event still reaches one instance per plugin)