Skip to content

fix(tui): disable unused child navigation defaults - #56199

Open
Dante-dan wants to merge 1 commit into
anomalyco:devfrom
Dante-dan:child-session-keys
Open

Dante-dan wants to merge 1 commit into
anomalyco:devfrom
Dante-dan:child-session-keys

Conversation

@Dante-dan

@Dante-dan Dante-dan commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #56153

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Disable the unused session.child.next / session.child.previous defaults and mark them deprecated. Their configuration names remain accepted for compatibility, following the existing retired-keybind pattern. Child sessions use the subagent picker, whose arrows switch composer tabs.

How did you verify your code works?

  • 39 existing config and keymap tests passed, including disabled defaults and explicit override compatibility.
  • bun typecheck in packages/tui, git diff --check, and the normal pre-push bun run check passed (35/35 tasks).
  • The full TUI suite encountered local filesystem permission errors and renderer timeouts; it is not a passing validation result.

Screenshots / recordings

Configuration cleanup; no rendered UI changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Added by the opencode bot (AI-generated).

Related: #56154

Public API: config defaults for keybinds session.child.next/previous change right/left → none; IDs still accepted (backwards compatible)

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The right/left defaults on session.child.next/session.child.previous were never wired to a registered command, so setting them to none removes dead bindings without taking away any working navigation. It follows the existing pattern for retired keybinds (diff.toggle, session.share).

I ran the #56153 reproduction against both the base and this branch. In a child session with the subagent picker open, right only switches the picker tab on both, as expected. The difference shows up in the resolved config, not on screen. bun test test/config-v2.test.tsx (21 pass) and bun run typecheck in packages/tui both pass.

Public API: the config defaults for the keybind IDs session.child.next and session.child.previous change from right/left to none. Both IDs are still accepted in config, so existing configs keep loading. This is backwards compatible.

Related: #56154

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI: session.child.next/previous keybind defaults are dead commands

1 participant