Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
There was a problem hiding this comment.
The corrected strings look right: each now matches the current English source (no more "Used" group in the timeline presets, Tùy chỉnh/Nâng cao/Tác nhân phụ, and the reversed search-provider label fixed). Type checks for packages/app and packages/ui pass, and so do the i18n tests in packages/app. I didn't run the web app myself, so I'm relying on your screenshot for how it looks.
Public API is unchanged (translation values and a doc only).
Two small things inline: the backticks around opencode pair will show as literal characters, and the glossary's first source points to a file that only exists in the still-open #55922.
| "server.connect.scan": "Quét mã QR", | ||
| "server.connect.scan.description": "Chĩa camera của bạn vào mã QR được hiển thị bởi cặp opencode.", | ||
| "server.connect.scan.invalid": "Đây không phải mã ghép cặp OpenCode. Quét mã được hiển thị bởi ghép cặp opencode.", | ||
| "server.connect.scan.description": "Hướng camera của bạn vào mã QR được hiển thị bởi `opencode pair`.", |
There was a problem hiding this comment.
These strings are shown as plain text (<p>{language.t("server.connect.scan.description")}</p> in servers/connect/scanner.tsx), so the backticks will appear literally on screen. English and the other locales write opencode pair without them. Keeping the command untranslated, as you did, is the right fix. Could you drop the backticks here and in server.connect.scan.invalid?
|
|
||
| ## Sources | ||
|
|
||
| - PR that added the Vietnamese Console locale: `packages/console/app/src/i18n/vi.ts` |
There was a problem hiding this comment.
packages/console/app/src/i18n/vi.ts doesn't exist on dev; it only comes in with the still-open #55922. The other glossaries list the PR that motivated them (e.g. - PR #9817: https://github.com/...). Could you point to this PR (and #55922 if you like) instead, so the source doesn't depend on another unmerged change?
92efb2e to
80e17dd
Compare
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Both fixed. Backticks — removed, since Glossary sources — now points at the PRs instead of a file that only exists in an unmerged branch: - PR #55925: https://github.com/anomalyco/opencode/pull/55925 (terminology fixes in this file)
- PR #55922: https://github.com/anomalyco/opencode/pull/55922 (Vietnamese Console locale)
- Existing Vietnamese copy on dev: `packages/app/src/runtime/i18n/vi.ts`, ...Also filed #55928 for this so the PR has a linked issue. |
|
Thanks, I checked both in 80e17dd: the pairing strings now read |
03166c8 to
987f5aa
Compare
987f5aa to
5c46d3f
Compare
Issue for this PR
Closes #55928
Type of change
What does this PR do?
Vietnamese has been in the app for a while, but machine translation left a number of strings that are wrong, unusable, or inconsistent with the rest of the dictionary. This corrects the ones that a Vietnamese reader would notice:
Phong tục(means "customs/etiquette")Tùy chỉnhTrình độ cao(means "high level")Nâng caoVỏ bọc(means "carapace")ShellChất phụ(means "secondary matter")Tác nhân phụđại lý phụ(means "sub-agency")Tác nhân phụĐã đổi tác tử(tác tửis a different noun)Đã đổi tác nhânopencode paircặp opencode/ghép cặp opencode(translated the command)lệnh opencode pairTìm kiếm nhà cung cấp(reversed)Nhà cung cấp tìm kiếmBất kì(misspelled)Bất kỳThe timeline preset descriptions also mentioned a "Used" group (
Đã sử dụng) that does not exist in the English source, which made the presets read as if they controlled something else. Thecompactandquietpresets were also missing from the dictionary and fell back to English, so both are added with the wording of the current English source.Alongside the fixes this adds
.opencode/glossary/vi.md, following the glossary convention the repo already documents, so the next translator uses the same words instead of inventing new ones per screen.Deliberately out of scope: the ~156 Vietnamese strings that are still missing from these two dictionaries. #51708 and #53174 already cover that, so this PR only corrects strings that already exist. The two
settings.timeline.row.turnDiffsstrings are included because they sit in the same panel as the fixes above and would otherwise show up as English in the screenshot.How did you verify your code works?
bun typecheckinpackages/appandpackages/ui— cleanprettier --checkon the changed files — cleanbun run checkfrom the repo root — 35/35 typecheck tasks, 0 oxlint errorsbun run typecheck:tscinpackages/appandpackages/uiafter the rebase — cleanen.tstext, and the dictionary type rejects an unknown keybun run --cwd packages/app dev) with the locale forced tovi, opened Settings, and read the values the running app actually resolved from the dictionary:Screenshots / recordings
Settings → Timeline detail in the running app, after this change.
Nâng caowasTrình độ caoandTệp đã thay đổiwas the EnglishChanged files:Checklist