Repository navigation
fix(core): run shell permission check even when command can't be parsed - #55883
Closed
Parker-Fawcett wants to merge 1 commit into
Closed
Parker-Fawcett wants to merge 1 commit into
Parker-Fawcett wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for picking up #54393! I think this duplicates an existing open pull request:
If you think one of those is missing something, for example a test for the PowerShell |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54393.
The shell tool skipped
permission.assertwhenever the scanner extracted no command nodes (e.g. a PowerShell command containing a bare--, or any other input the grammar turns into zero nodes). Such commands bypassed configuredshellrules entirely.Now the raw command is checked as one opaque resource, so it still has to satisfy the rules; with no matching rule the default effect is
ask. An "always" reply is deliberately not persisted for these (save: []), so no standing allow is minted from unparsed text.How to verify: new test
denies shell commands the legacy scanner turns into no commandsinpackages/core/test/tool-shell.test.ts(fails ondev, passes with the fix). Also ranpermission.test.ts(105 pass) andbun typecheckinpackages/core(clean); the 6tool-shell.test.tsfailures in conditional-process-substitution/compound-syntax cases pre-exist ondevin this environment.