Repository navigation
Conversation
arvsrn
force-pushed
the
dialog-footer-style
branch
from
October 15, 2026 19:17
f30e52a to
d734ab0
Compare
arvsrn
force-pushed
the
dialog-footer-actions
branch
from
October 15, 2026 19:17
bef9590 to
3f42501
Compare
This was referenced Oct 15, 2026
arvsrn
force-pushed
the
dialog-footer-actions
branch
from
October 16, 2026 08:42
3f42501 to
724004f
Compare
arvsrn
force-pushed
the
dialog-footer-style
branch
from
October 16, 2026 08:42
d734ab0 to
1577714
Compare
arvsrn
force-pushed
the
dialog-footer-actions
branch
from
October 16, 2026 09:16
724004f to
85001e0
Compare
arvsrn
added a commit
that referenced
this pull request
Oct 16, 2026
Lands the rest of the dialog redesign stack, all behind the new-designs experiment: - put dialog search in the title row (#55800) - hide dialog search on short lists (#55801) - read the experiment through useNewDesigns (#55802) - raise dialog footers (#55805) - standardize dialog footer actions (#55806) - style selected dialog list rows (#55807) - show list overflow indicator (#55808) - restyle dialog headers (#55809) - use vivid agent colors (#55810)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (merge bottom-up):
devIssue for this PR
N/A. Part of the new dialog designs.
Type of change
What does this PR do?
Footers take data instead of JSX:
Secondary actions sit on the left (dialog-level), primary on the right (selected item / main action).
legacyFooterkeeps the old UI with the experiment off and goes away when it graduates.Under the experiment:
label keyactions.connect integration,remove account,open link enter,delete d,copy c).New key bindings only apply under the experiment; production keybinds are unchanged.
DialogPrompt's extraactions(e.g. worktree name's generate) go into the primary group to the left ofsubmit, matching the design (generate name tab submit enter). The legacy footer keeps the current order.Note: the hover is only visible in
opencode2for now. Other themes map dialog action hover to the band color; fixing that touches production themes, so it's left for later.How did you verify your code works?
Rendered the affected dialogs before and after with the experiment off and compared the frames (text and colors); they are identical. Typecheck and TUI tests pass apart from the two shell-output tests that also fail on dev. Tested the experiment-only bindings (delete worktree
d, esc, enter) on and off, and hover with a mock mouse inopencode2.Screenshots / recordings
None yet. All visual changes are behind the
new-designsexperiment (Experiments dialog → New designs, then pick theopencode2theme).Checklist