Skip to content

feat(tui): standardize dialog footer actions behind new designs experiment - #55806

Closed
arvsrn wants to merge 8 commits into
devfrom
dialog-footer-actions
Closed

arvsrn wants to merge 8 commits into
devfrom
dialog-footer-actions

Conversation

@arvsrn

@arvsrn arvsrn commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Stack (merge bottom-up):

Issue for this PR

N/A. Part of the new dialog designs.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Footers take data instead of JSX:

<DialogLayout footer={{ actions: { secondary: [...], primary: [...] } }} legacyFooter={<old JSX>} />

Secondary actions sit on the left (dialog-level), primary on the right (selected item / main action). legacyFooter keeps the old UI with the experiment off and goes away when it graduates.

Under the experiment:

  • Custom button footers (alert, confirm, help, export, update, delete worktree, highlights) become standard label key actions.
  • Actions have a hover state and faint shortcut labels.
  • Navigation-only hints (scroll, esc back, change ←/→) are removed.
  • Labels and keys follow the designs (connect integration, remove account, open link enter, delete d, copy c).

New key bindings only apply under the experiment; production keybinds are unchanged.

DialogPrompt's extra actions (e.g. worktree name's generate) go into the primary group to the left of submit, matching the design (generate name tab submit enter). The legacy footer keeps the current order.

Note: the hover is only visible in opencode2 for now. Other themes map dialog action hover to the band color; fixing that touches production themes, so it's left for later.

How did you verify your code works?

Rendered the affected dialogs before and after with the experiment off and compared the frames (text and colors); they are identical. Typecheck and TUI tests pass apart from the two shell-output tests that also fail on dev. Tested the experiment-only bindings (delete worktree d, esc, enter) on and off, and hover with a mock mouse in opencode2.

Screenshots / recordings

None yet. All visual changes are behind the new-designs experiment (Experiments dialog → New designs, then pick the opencode2 theme).

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@arvsrn
arvsrn changed the base branch from dialog-footer-style to dev October 16, 2026 09:16
@arvsrn
arvsrn force-pushed the dialog-footer-actions branch from 724004f to 85001e0 Compare October 16, 2026 09:16
arvsrn added a commit that referenced this pull request Oct 16, 2026
Lands the rest of the dialog redesign stack, all behind the new-designs experiment:

- put dialog search in the title row (#55800)
- hide dialog search on short lists (#55801)
- read the experiment through useNewDesigns (#55802)
- raise dialog footers (#55805)
- standardize dialog footer actions (#55806)
- style selected dialog list rows (#55807)
- show list overflow indicator (#55808)
- restyle dialog headers (#55809)
- use vivid agent colors (#55810)
@arvsrn

arvsrn commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

Landed in #55810, which merged the rest of the dialog redesign stack as one commit (00e7472).

@arvsrn arvsrn closed this Oct 16, 2026
@arvsrn
arvsrn deleted the dialog-footer-actions branch October 16, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant