Repository navigation
Conversation
Contributor
|
Thanks for putting this together, @gaojunran! On 2026-10-10 the Please open it again with |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48563
Type of change
What does this PR do?
The prompt footer shows
agent · model · variantas plain text (#48563). This wires each label to the picker its keyboard shortcut already opens, by dispatching the existing keymap commands on click: agent →agent.list, model and provider →model.list, variant →variant.list.Clicks only fire on a plain left click: the handlers in
ui/click.tsignore a press released on a different cell or ending with an active text selection, so drag-to-select over the footer keeps working. The guard mirrors the closed v1 attempt #53871, which the bot asked to redo against v2.How did you verify your code works?
bun test test/component/prompt-metadata-click.test.tsx— renders the metadata row, clicks each label and asserts the picked target (agent,model,variant); also asserts that releasing a transcript selection over the labels, and pressing a label then releasing off it, do not trigger a pick.bun run typecheckandbunx oxlinton the touched files.bun testin packages/tui: 1464 pass. The only 2 failures (dialog-shell-outputtimeouts) reproduce identically on the unmodified v2 base commit, so they are pre-existing environment flakes, not from this change.Screenshots / recordings
Interaction-only change — the footer renders exactly as before, no visual diff.
Checklist