Repository navigation
docs(plugin): correct catalog migration guidance - #55657
Open
1052326311 wants to merge 1 commit into
Open
1052326311 wants to merge 1 commit into
1052326311 wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The docs fix looks correct. I checked the new migration paragraph against the current plugin types in packages/plugin/src/effect/provider.ts and model.ts and their Promise versions. ProviderEditor.update(providerID, fn), ModelEditor.update(providerID, modelID, fn) and transform/reload on both domains all exist. I also checked it against the published @opencode-ai/[email protected], whose v2/effect/catalog.d.ts defines the CatalogDraft.provider.update / model.update signatures the paragraph maps from. No other build docs still mention a catalog domain.
Public API: unchanged (documentation only).
No blocking concerns.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #55628
Type of change
What does this PR do?
Remove the nonexistent
catalogscontext domain from the V1 migration guide. Explain how the early V2ctx.catalogtransform and reload calls map to the currentctx.providerandctx.modeldomains.How did you verify your code works?
npm exec --yes [email protected] -- prettier --check services/www/src/docs/content/build/plugins/migrate-v1.mdxpassed.git diff --checkpassed.Screenshots / recordings
Not applicable; documentation text only.
Checklist