Repository navigation
fix: preserve revert consistency - #55315
Closed
CasualDeveloper wants to merge 1 commit into
Closed
CasualDeveloper wants to merge 1 commit into
CasualDeveloper wants to merge 1 commit into
Conversation
Park execution while a revert is staged and serialize revert mutations with prompt and synthetic admission. Commit replacement prompts, changed selection, and optional context atomically with the revert, retaining pending input before its chronological boundary. Apply selection intent only to winning steer admissions. Keep queued requests and same-ID retries from reapplying selection, share the short admission lock with explicit switches, and expose intent to prompt hooks without claiming it is already committed. Keep projected reads in SessionStore and scope plugin setup and hook admission bypasses to their active invocation. Serialize client mutations without delaying optimistic display or releasing same-ID retries early. Do not hold the input FIFO through shell completion or certify agent selection from reconciled admission receipts. Keep pending start-snapshot readiness interruptible when a provider fails before first assistant publication, so Stop can release execution and subsequent revert staging. Retain uninterruptible final step/tool cleanup. Bind delayed undo to its captured Session and paginated chronological history, and preserve queue rollback and full-clear redo. Regenerate the public clients and API documents from the prompt schema. Closes anomalyco#37751, anomalyco#44357
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for keeping this up to date after #46974 was closed. The bug in #37751 is real, but at about 2,300 non-test lines across core, server, protocol, plugin, client, app and TUI, this is too large to review as one pull request. It also mixes a public API change with several separate fixes. Could you split it into smaller, focused pull requests that can each be reviewed on its own? For example:
You're welcome to open those. Smaller pull requests are much easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37751, #44357
Supersedes #46974, #37752, #42461
Type of change
What does this PR do?
This replaces #46974 after cleanup and V2's promotion to
dev. Both PRs are now closed; the automated scope review requests smaller follow-ups.A staged revert now parks execution. Its replacement prompt, changed selection, and optional context commit together; earlier pending input survives. Client Undo uses the session/history captured at the gesture, while ordered admission keeps optimistic input immediate and preserves queue rollback and full-clear redo.
Selection applies only to winning new admissions with requested and prepared steer delivery. Plugin admission bypasses expire with their invocation, and Stop stays interruptible before pending snapshot publication.
How did you verify your code works?
Verified
eb76193b51on frozendevate9def88a77:bun run check: 36 typechecks pass; zero lint errors, 1,457 warnings. Generated checks and website build/link validation pass.Screenshots / recordings
No visual redesign; the production UI is exercised with isolated fixtures.
Checklist
Process: human-directed, with agentic assistance from Anthropic/Claude and OpenAI/gpt-6.1-sol.