Repository navigation
Conversation
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. I reproduced the failure on the base with a small test: load two locations, delete one directory, call LocationServiceMap.reload(). Reload fails with FileSystem.DirectoryNotFoundError. With this change it succeeds, the other location stays loaded, the deleted one isn't left in the map, and recreating that directory and loading it again works. location-layer.test.ts and the core typecheck pass.
Public API unchanged: the reload route and CLI just stop failing when a location's directory is gone.
No blocking concerns. Pruning the stale worktree rows asked for in #54827 is still separate, as you noted.
Related: #54827
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Addresses the reload failure in #54827. Inventory reconciliation is separate; the existing worktree refresh API already prunes missing directories.
Type of change
What does this PR do?
Skip a deleted location when reload encounters
FileSystem.DirectoryNotFoundError, logging a warning so the remaining locations can reload. Other boot failures still fail the request.How did you verify your code works?
Changed-file oxlint and
git diff --checkpassed. Existing core missing-directory recovery test (1) and worktree refresh/pruning tests (3) passed. The broader location suite hit local 5s timeouts; core typecheck was stopped after no output.bun run checkfailed because Node 22 could not load the repository's TypeScript oxlint plugin. End-to-end reload reproduction has not completed locally.Screenshots / recordings
No UI change.
Checklist
Added by the opencode bot (AI-generated).
Related: #54827