Repository navigation
Conversation
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good: the change is minimal and correct.
On Linux I ran the #54828 reproducer against the same ZipWriter setup as writeZip. On the base, each entry's data descriptor starts with the CRC. With this change, every descriptor starts with PK\x07\x08. The zip still reads back through zip.js ZipReader and unzip -t. dataDescriptorSignature is a documented option in the pinned zip.js 2.7.62, and the desktop typecheck passes. I couldn't check ditto or Archive Utility because that needs macOS; your macOS ditto test covers it.
Public API: unchanged. The exported zip remains a standard zip; only the optional descriptor signature is added.
No concerns.
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #54828
Type of change
What does this PR do?
Enable Zip.js data descriptor signatures for exported debug logs. macOS
dittorejects the unsigned descriptors produced by the default writer options.How did you verify your code works?
Couldn’t read pkzip signature; signed descriptors extracted successfully withditto, including the manifest and log.bun test --timeout 30000 electron-builder.config.test.ts).bun run typecheck). Rootbun run check: lint/SDK docs completed with warnings and no errors; workspace typechecks could not complete because Astro telemetry in the posts/www packages tried to write outside the sandbox (EPERM). A retry with telemetry disabled had the same environment failure.Screenshots / recordings
No UI change.
Checklist