Repository navigation
Conversation
The Traditional Chinese (zht) community uses Discord, not Feishu. The footer previously grouped zht together with zh (Simplified Chinese) to show the Feishu link, but only Simplified Chinese uses Feishu. - footer.tsx: restrict the Feishu branch to zh so zht falls through to Discord - README.zht.md: replace the Feishu link with Discord - zht.ts: correct footer.feishu from Simplified 飞书 to Traditional 飛書 (kept for dictionary completeness parity with en.ts, which also retains it) Co-Authored-By: 張景嵐 <[email protected]>
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
The change looks correct. The footer now sends only zh to Feishu, so zht falls through to the existing Discord entry (footer.discord is already in zht.ts). README.zht.md uses the same Discord link as the other READMEs, and the console app type-checks with the change. I checked it by reading the code and did not render the console page.
Public API: unchanged.
The only open point is not technical: this partly reverts #16908 for Traditional Chinese readers, so maintainers need to agree on which community link zht should get.
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Fixes the problem reported in #27642 (closed as not-planned by the cleanup bot while the fix was pending review).
Type of change
What does this PR do?
English
Credit: PR #27640 by @changchinlan already solved this cleanly, but it was auto-closed by the stale-PR cleanup (created >1 month ago, <2 positive reactions) — not for any technical reason, and it was never reviewed. This PR revives that contribution.
Background: #16908 routed both the
zhandzhtlocales to a Feishu group. The Traditional Chinese (zht) audience is primarily in Hong Kong, Taiwan, Macau, and overseas communities, where Feishu has very little reach. Practical barriers for that audience joining via Feishu:This PR keeps Feishu for
zh(Simplified Chinese) — respecting the intent of #16908 for that audience — and routeszhtback to the existing Discord community:packages/console/app/src/component/footer.tsx: narrow the Feishu branch fromlocale === "zh" || locale === "zht"tolocale === "zh".README.zht.md: replace the Feishu link with Discord.packages/console/app/src/i18n/zht.ts: correct thefooter.feishutranslation from the Simplified飞书to the Traditional飛書. The key is kept (matchingen.ts, which also retains it for dictionary completeness) even though thezhtlocale no longer references it from the footer.No changes to the
zhlocale, theendict, or the/feishuredirect route.中文
致謝：@changchinlan 先前的 PR #27640 已乾淨地解決此問題，但因閒置被自動清理機制關閉（建立超過 1 個月、正面反應少於 2）—— 並非技術因素，且從未被 review。本 PR 接手該貢獻。
背景：#16908 將
zh與zht兩個語系都導向飛書群組。繁體中文（zht）受眾主要分布於港澳、台灣及海外華人社群，飛書在這些地區普及度極低。透過飛書加入的實際障礙：本 PR 保留
zh（簡體中文）的飛書設定（尊重 #16908 對該受眾的用意），並將zht重新導回既有的 Discord 社群：packages/console/app/src/component/footer.tsx：將飛書分支從locale === "zh" || locale === "zht"縮減為locale === "zh"。README.zht.md：將飛書連結改為 Discord。packages/console/app/src/i18n/zht.ts：將footer.feishu從簡體「飞书」修正為繁體「飛書」。保留此鍵（與en.ts一致，後者亦為字典完整性保留它），即便zht語系已不再於頁尾引用。未變更
zh語系、en字典或/feishu重導路由。How did you verify your code works?
language.locale()returns"zht"for Traditional Chinese visitors, which now falls through to the Discord branch infooter.tsx(condition simplified tolocale === "zh"; type-equivalent, no new code paths).zht.tsare clean;satisfies Dictstill passes because every key remains present (footer.feishuoverride kept, only corrected to Traditional).footer.discordalready exists inzht.ts, so the Discord label renders correctly forzht.footer.feishureferences — only thezhandendicts remain, both intentional.tsgo --noEmittypecheck could not run in my environment because package dependencies aren't installed; the change is type-equivalent and minimal.Screenshots / recordings
N/A — link-target and text change only; no visual layout change.
Checklist
Added by the opencode bot (AI-generated).
Related: #27642, #16908