Repository navigation
fix(core): hide newer Bedrock bare IDs that require inference profiles - #54486
Merged
Merged
Conversation
Co-Authored-By: Claude <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This looks good to me. On the base, running the models.dev catalog through ModelsDevPlugin offers all six bare IDs for amazon-bedrock. With this change, all six are hidden. Their us./global. profile versions, bare Opus 5.5 and bare Sonnet 4.6 stay available. All six IDs match bare catalog entries exactly, and none is routed to Mantle. I couldn't check the Bedrock-side ValidationException without AWS credentials, so that part relies on your probes in #54485. The existing models-dev and amazon-bedrock plugin tests pass, and packages/core type-checks.
Public API: unchanged. This only filters which catalog entries are offered.
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @rekram1-node for moving the Bedrock exclusion into the models.dev plugin in #48081; that made this a six-row follow-up.
Issue for this PR
Closes #54485
Type of change
What does this PR do?
Adds six bare Bedrock IDs to
BEDROCK_PROFILE_ONLY_IDS: Claude Sonnet 5.5 and Haiku 5.5 (both released after #48081), Llama 4 Maverick/Scout and Palmyra X4/X5. They go through Converse, V2 sends the ID unchanged, and Bedrock only accepts them as inference profiles, so the unsuffixed picker entry fails on every call. Theirus./global.twins stay.Opus 5.5 stays visible because it is
ON_DEMANDin eu-west-2 (a live call there returned 200), the same reason the comment gives for 4.6, so the comment now names it. I did not add a test, since #48081 dropped the list-pinned one.How did you verify your code works?
dev@ e31136bModel.available()(models.dev catalog throughModelsDevPlugin)us./global.twins, bare Opus 5.5 and Sonnet 4.6, Mantleopenai.gpt-6-solValidationException(on-demand not supported)us.twinbun typecheckinpackages/core, oxlint and prettier pass. The full probe table is in #54485.Screenshots / recordings
Not a UI change.
Checklist