Repository navigation
fix(app): restore terminal toggle in v2 session header - #54189
steevej-2077 wants to merge 1 commit into
Conversation
The terminal toggle only existed in the legacy session header. The v2 header (SessionHeaderV2Actions) was ported with the status and review actions only, and the legacy layout is now retired, so the button is no longer reachable and the panel can only be opened via /terminal or ctrl+`. Add the toggle back to the v2 header, reusing the existing toggleTerminal handler, and add the missing terminal icon to the v2 icon set.
github-actions
Bot
added
needs:issue
needs:compliance
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for tracking this down and for the clear write-up, @steevej-2077! The If the same affordance is missing in v2 (the |
|
The following comment was made by an LLM, it may be inaccurate: |
Problem
The terminal toggle button only exists in the legacy session header. The v2 header (
SessionHeaderV2Actions) was ported with the status and review actions only, and since the legacy layout was sunset the button is no longer reachable anywhere:/terminalorctrl+, but there is no visible affordance.Related: #48025, #29829, #36818.
Changes
SessionHeaderV2Actions, reusing the existingtoggleTerminalhandler (same tooltip + keybind pattern as the review action,aria-controls="terminal-panel").terminalicon to the v2 icon set (same path as the legacy icon,0 0 20 20viewBox like the other header icons).Testing
bun run --cwd packages/app typecheck✅bun run --cwd packages/ui typecheck✅bunx prettier --checkon both files ✅bunx oxlinton both files: same 7 pre-existing warnings before and after ✅bun run --cwd packages/app test:unit: 724 pass, 0 fail ✅