Repository navigation
fix(core): restore legacy sessions in markerless projects - #54048
EnglandLobster wants to merge 1 commit into
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. I reproduced the problem with the CLI from source: in a non-Git directory with an existing project and imported V1 sessions under global, session list is empty on v2. With this change the directory's session is adopted, with path set to "" and its timestamps kept, and a session in a subdirectory stays under global. The new regression test fails on the base and passes here. The nearby core, schema and client suites behave the same as on the base, and typechecks pass. I have no blocking concerns.
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #53450. Related: #51176 and the migration-time repair in #51935.
Type of change
What does this PR do?
Opening a non-Git/Hg directory creates a V2 project but skips the resolution event, leaving imported V1 sessions under
globaland hidden from project-scoped lists.Publish resolution for markerless directories too. An optional
exactflag keeps both the database projector and client adoption limited to that directory; repository resolution retains recursive adoption. Existing affected project rows recover on their next resolution. Adoption resets the relative path to""and preserves session timestamps and history.Unlike #51935's migration-time pass over known projects, this handles directory discovery at runtime. It uses the existing durable event/transaction path rather than adding another database repair loop.
How did you verify your code works?
global.bun run generateinpackages/client.bun run check(lint and typechecks) passed.Screenshots / recordings
Not a visual change.
Checklist