Skip to content

fix(app): only treat the builtin sidecar as local - #53628

Closed
Embiggenerd wants to merge 2 commits into
anomalyco:devfrom
Embiggenerd:wsl-localhost-picker
Closed

fix(app): only treat the builtin sidecar as local#53628
Embiggenerd wants to merge 2 commits into
anomalyco:devfrom
Embiggenerd:wsl-localhost-picker

Conversation

@Embiggenerd

@Embiggenerd Embiggenerd commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #52205

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This PR makes it so that only servers created directly by the desktop application use the native file picker. Before, any localhost server would use the native file picker. This was a problem if the server and the app are in different file systems, such as WSL. Using a Windows file picker for a Linux file system causes bugs, such as sending a file path the server can't use.

The trade-off is that users using opencode serve on localhost will always get the in-app file picker instead of the native picker. It will still work but they may be missing features. I interpret the purpose of opencode serve to be for running in separate file environments, so I think this is okay. I may be off on that.

How did you verify your code works?

I tested 2 paths manually:

  1. Regular Windows use with the app starting the server. The native picker was used correctly.
  2. Starting a server in WSL and talking to the app in Windows. The in-app picker was used correctly.

Screenshots / recordings

In the vid, I look pick a file in the server the app started, then I show that the 'wsl' server is running locally and it uses the in-app file picker.

wsl-picker.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

Igor Atakhanov added 2 commits October 5, 2026 14:51
Igor Atakhanov
fix(app): only treat the builtin sidecar as local
68e6187
Igor Atakhanov
Merge branch 'v2' of https://github.com/anomalyco/opencode into wsl-l…
ac9f8a7 
…ocalhost-picker

# Conflicts:
#	packages/app/src/runtime/server/registry.tsx
#	packages/app/src/runtime/server/runtime.tsx
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Hey! Your PR title Wsl localhost picker doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@Embiggenerd Embiggenerd changed the title Wsl localhost picker fix(app): only treat the builtin sidecar as local Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@Embiggenerd Embiggenerd mentioned this pull request Oct 6, 2026
Closed
@github-actions github-actions Bot mentioned this pull request Oct 6, 2026
Open
@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:34
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hona Hona Awaiting requested review from Hona
@Brendonovich Brendonovich Awaiting requested review from Brendonovich

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows Desktop passes WSL UNC paths to a Linux server, causing HTTP 500 errors and persistent startup crashes

1 participant

@Embiggenerd