Repository navigation
fix(tui): keep the subagent activity filter across navigation - #53318
Merged
Merged
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ctrl+ain the subagents composer is now a pure toggle: choosing a subagent withenterkeeps the active/inactive filter instead of snapping back to "active".Why
The session route is keyed by
sessionID, so navigating to a subagent remounts the composer andSubagentsTabrecreated its store withactive: true. Closing the composer also explicitly reset the filter.How
useStorage().memory("subagents-filter")so it survives the route remount for the life of the TUI process (not persisted to disk).composer.subagent.toggle-activitychanges it; closing the composer still resets the selection, but no longer the filter.Verification
composer-keymap.test.tsxmounts the composer keyed by route session like the app does, toggles to inactive, pressesenter, and checks that the child session still shows inactive subagents, then toggles back. It fails onorigin/v2and passes with this change.bun test test/cli/tui/composer-keymap.test.tsx(7 pass) andbun run typecheckinpackages/tui.origin/v2(4fb8007) and this branch, with one finished and one running background subagent: before,enteron the finished subagent reopens the picker on "Running" only. After, the picker stays on inactive andctrl+astill flips it back. The demo video is in the requesting Slack thread, because the GitHub App token can't upload PR attachments.Requested by: @nexxeln (nexxel via Slack)