Skip to content

fix(tui): match animation setting default to runtime - #53293

Closed
aihaipeng wants to merge 6 commits into
anomalyco:devfrom
aihaipeng:animation-setting-default
Closed

fix(tui): match animation setting default to runtime#53293
aihaipeng wants to merge 6 commits into
anomalyco:devfrom
aihaipeng:animation-setting-default

Conversation

@aihaipeng

@aihaipeng aihaipeng commented Oct 5, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #52577

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

When animations is absent from cli.json, the settings dialog uses false, while the runtime defaults to true.

Change the dialog default to true. Explicit true and false values are unchanged.

How did you verify your code works?

  • Extended packages/tui/test/app-lifecycle.test.tsx to cover unset, false, and true values. The unset case fails before the fix and passes after.
  • Targeted TUI tests: 103 passed; 2 terminal selection and pane-management cases skipped on Windows.
  • bun run check and git diff --check passed.
  • Checked the default, on/off toggling, and persistence after restarting the TUI.

Screenshots / recordings

The animations key is absent from cli.json in both cases.

Before After
Before: Animations shows off After: Animations shows on

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@aihaipeng aihaipeng mentioned this pull request Oct 5, 2026
Open
@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:33
@opencodejr opencodejr Bot mentioned this pull request Oct 29, 2026
Closed
3 of 6 tasks
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tui: settings dialog shows Animations as off while animations are enabled by default

1 participant

@aihaipeng