fix(core): keep sessions active while background work is outstanding by benrap · Pull Request #53211 · anomalyco/opencode

benrap · 2026-10-04T19:11:56Z

Issue for this PR

Closes #45560
Closes #48826
Closes #48548

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

A session with outstanding durable background work (a background shell, or a subagent waiting on its child) was reported as idle as soon as its foreground turn ended. Clients then showed the completion tick even though work was still running, a subagent with pending background work was reported to its parent as completed early, and the TUI hid the sidebar for subagent sessions.

This adds a non-terminal waiting session status. While a settled session still has pending background work, core publishes waiting and withholds the terminal event, so clients keep the session active until that work is acknowledged. Subagent finalization awaits the child's pending background notifications before returning its final response. The TUI treats waiting as busy (spinner, no tick) and renders the sidebar for subagent sessions by removing the parentID gate.

How did you verify your code works?

Ran the focused test files touched by these commits from packages/core:

bun run script/test.ts test/session-execution.test.ts test/job.test.ts test/tool-subagent.test.ts

Result: 64 pass, 0 fail, 366 expect() calls across 3 files.

Coverage lives in packages/core/test/session-execution.test.ts, packages/core/test/job.test.ts, and packages/core/test/tool-subagent.test.ts.

Screenshots / recordings

N/A (status/behavior change).

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

…output Subagent finalization now waits for the child's outstanding durable background work to be acknowledged before producing the final response.

Adds a non-terminal waiting member to the SessionStatus union and regenerates the client type surface.

Adds Job.pendingFor/Job.awaiting as the shared source of truth for a Session's outstanding durable background work, refactors finalText to use it, and publishes a non-terminal waiting status when a settled Session still has background work to acknowledge. Also supplies the required id in PR anomalyco#49305's background-await test; the adopted diff omitted it and StartInput.id was already required, so the test did not typecheck on this base.

Projects the ephemeral session.status waiting event into the client data layer, maps it through the app session model and UI provider, widens the TUI plugin data type, and shows a waiting label in the TUI footer.

…tion SubagentCompletion.finalText resumed the recovered child via Session.Service.resume, which closes over the outer/global SessionExecution. The recovery tests inject a fresh SessionExecution wired to a test drain reachable only through the layer-provided execution, so the test drain never ran and three SessionRestart background recovery tests hung. Pass a sessions shim whose resume delegates to the layer-provided execution, restoring the layer-wiring contract while keeping finalText's await-background-work behavior.

While background work is outstanding the core publishes `waiting` and withholds `Execution.Succeeded` (releasing the claim), and the TUI treats `waiting` as running/busy so the subagent row shows the spinner instead of the checkmark; the terminal (and tick) appears only after the background work completes.

Remove the `parentID` guard in `sidebarVisible()` so the core sidebar (and its `sidebar.content` slot) renders for subagent sessions.

github-actions · 2026-10-04T19:12:06Z

Hey! Your PR title Surface session waiting status and remove the parentID subagent sidebar gate doesn't follow conventional commit format.

Please update it to start with one of:

feat: or feat(scope): new feature
fix: or fix(scope): bug fix
docs: or docs(scope): documentation changes
chore: or chore(scope): maintenance tasks
refactor: or refactor(scope): code refactoring
test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

github-actions · 2026-10-04T19:12:25Z

The following comment was made by an LLM, it may be inaccurate:

github-actions · 2026-10-04T19:32:34Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

github-actions · 2026-10-04T19:32:35Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

Ploppy3 · 2026-10-16T06:58:25Z

@benrap @thdxr will this ever be fixed? This long standing issue is making OpenCode difficult to use compared to its competitors.

github-actions · 2026-11-04T22:23:19Z

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

The PR was created more than 1 month ago
The PR had fewer than 2 positive reactions
Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

benrap added 7 commits October 3, 2026 11:58

fix(core): await background notifications before finalizing subagent …

8fdc32f

…output Subagent finalization now waits for the child's outstanding durable background work to be acknowledged before producing the final response.

feat(schema): add waiting session status

2ce564b

Adds a non-terminal waiting member to the SessionStatus union and regenerates the client type surface.

feat(tui): surface waiting session status

c8457d9

Projects the ephemeral session.status waiting event into the client data layer, maps it through the app session model and UI provider, widens the TUI plugin data type, and shows a waiting label in the TUI footer.

feat(tui): render the session sidebar for subagent sessions

c6349d5

Remove the `parentID` guard in `sidebarVisible()` so the core sidebar (and its `sidebar.content` slot) renders for subagent sessions.

benrap requested review from Brendonovich and Hona as code owners October 4, 2026 19:11

github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:title labels Oct 4, 2026

benrap changed the title ~~Surface session waiting status and remove the parentID subagent sidebar gate~~ fix(core): keep sessions active while background work is outstanding Oct 4, 2026

github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:title labels Oct 4, 2026

github-actions Bot added the needs:issue label Oct 4, 2026

benrap closed this Oct 4, 2026

benrap deleted the benrap/session-waiting-status branch October 4, 2026 19:40

benrap reopened this Oct 4, 2026

benrap force-pushed the benrap/session-waiting-status branch from 696130b to c6349d5 Compare October 4, 2026 20:02

thdxr changed the base branch from v2 to dev October 10, 2026 19:32

github-actions Bot removed the needs:issue label Oct 10, 2026

Petr28 mentioned this pull request Oct 15, 2026

ACP: parent's auto-resumed turn after background subagent completion emits zero session/update (dropped by background turn) #55760

Closed

opencode-agent Bot mentioned this pull request Oct 15, 2026

fix(cli): deliver resumed ACP parent turn updates #55834

Open

3 tasks done

opencode-agent Bot mentioned this pull request Oct 17, 2026

[FEATURE]: Add an indication that a model is waiting for background task #56328

Closed

1 task done

ysm-dev mentioned this pull request Oct 18, 2026

web: session icon shows no progress indicator while a background shell runs #56660

Open

opencodejr Bot mentioned this pull request Oct 30, 2026

任务是否结束的表示不明确 #60423

Closed

github-actions Bot closed this Nov 4, 2026

github-actions Bot added the automated-pr-cleanup label Nov 4, 2026

Navigation Menu

Repository navigation

fix(core): keep sessions active while background work is outstanding - #53211

fix(core): keep sessions active while background work is outstanding#53211
benrap wants to merge 7 commits into
anomalyco:devfrom
benrap:benrap/session-waiting-status

benrap commented Oct 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

Ploppy3 commented Oct 16, 2026

Uh oh!

github-actions Bot commented Nov 4, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

benrap commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

Ploppy3 commented Oct 16, 2026

Uh oh!

github-actions Bot commented Nov 4, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benrap commented Oct 4, 2026 •

edited

Loading