Repository navigation
Conversation
Advertise _meta.steering.supported on initialize and handle
_session/steering. A steer on a busy session is admitted with
session.prompt({ noReply: true }) for the running loop to pick up on its
next step; an idle session replies promptRequired and sends nothing.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
1 task done
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #53042
Refs #44877
Type of change
What does this PR do?
Interim until ACP v2 (#44877); the v2 path would replace this.
Adds the
_session/steeringACP extension so a client can redirect a runningturn.
initializenow advertises_meta.steering.supported. The handler checkssession.status: if the session is busy it adds the message withsession.prompt({ noReply: true }), which the running loop picks up on its nextstep, and replies
injected. If the session is idle it repliespromptRequiredand sends nothing, so a steer never starts an unrequested turn.How did you verify your code works?
bun test test/acppasses (142 tests) andbun run typecheckis clean.opencode acpfrom source and sentinitialize: the response includes_meta.steering.supported: true. A_session/steeringrequest for an idlesession returns
promptRequired, and an unknown method still returns -32601.Checklist