Repository navigation
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #51247
Type of change
What does this PR do?
With
HTTPS_PROXYset and noNO_PROXY, localhost TUI-to-service API callsgo through the proxy and fail. Desktop already upserts loopback into
NO_PROXYat startup (packages/desktop/src/main/sidecar.ts); the CLI hadno equivalent. This ports that upsert to CLI startup so local calls stay
direct.
I reproduced this failure mode locally with a fake proxy, but
#51247 has no repro details (no OS, steps, or version beyond v2.0.12), so I
can't guarantee this is what the reporter hit. I have commented on the issue and am happy to narrow or extend the
fix if they share their setup.
How did you verify your code works?
I ran these locally:
bun test test/no-proxy.test.tsinpackages/cli: 3 passbun run typecheckinpackages/cli: cleanAnd also:
Screenshots / recordings
Not needed, this is not a UI change.
Checklist