Repository navigation
Conversation
The composer control row overflowed on narrow viewports: the model chip rendered its full name (~200px+) plus the agent and effort selects, and the tooltip trigger divs wrapping each control carried no min-width, so nothing could shrink. Add min-w-0 to every control wrapper/trigger and cap chip widths at 140-150px below the sm breakpoint (restoring the desktop caps at sm and up) so names ellipsize instead of pushing the row out of the viewport. Co-Authored-By: Afonso Dutra Nogueira Filho <[email protected]>
Author
|
cc @Hona @Brendonovich — could you review and approve? Mobile composer fix: model + effort chips now ellipsize below the sm breakpoint instead of overflowing the viewport. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Co-Authored-By: Afonso Dutra Nogueira Filho <[email protected]>
afonsoft
changed the title
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #43295
Type of change
What does this PR do?
Two mobile fixes in the composer control row (v1
PromptInput+ v2PromptInputV2):1. Overflow on narrow viewports. The model chip renders its full name (e.g. "LongCat 2.5 Preview Free", ~200px+) alongside the agent select, effort/variant select and submit button, overflowing the right edge — and in V2 rendering the controls over the send button, so tapping "send" opens a selector instead. Root cause: the tooltip trigger divs wrapping each control (and the
data-componentwrapper divs in v1) had nomin-widthoverride, so flex items could not shrink below min-content. Fix:min-w-0across the chain + smaller caps belowsm(model 140–150px, agent/variant 110px). Desktop widths unchanged; chips now ellipsize on mobile.2. Touch targets below 44px. Composer chips and icon buttons are 28–32px tall (
h-7,size-8, ButtonV2normal/large), below the WCAG 2.5.5 / platform HIG 44px recommendation. Fix:pointer-coarse:variants grow the interactive box to 44px (h-11!/size-11!) only on touch devices. Because the controls areghost/ghost-mutedvariants, the visual footprint is unchanged on mobile — only the hit region grows into the surrounding dead space.!is required because component heights come from[data-size]attribute selectors that outrank plain utilities.How did you verify your code works?
bun typecheckinpackages/session-ui,packages/appandpackages/opencode;bun turbo typecheckacross the monorepo — clean (runs in the pre-push hook).pointer-coarseis a built-in Tailwind v4 variant (@media (pointer: coarse)), so nothing changes on mouse/desktop.Screenshots / recordings
N/A — no visual change on desktop; on mobile the model/effort chips ellipsize instead of overflowing, and tap targets reach 44px.
Checklist