Repository navigation
fix(app): restore custom provider creation on v2 - #52653
Closed
rekram1-node wants to merge 1 commit into
Closed
rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51330
Closes #50650
Type of change
What does this PR do?
The custom-provider form always threw an unavailable error and still built V1 config. Restore saving through V2: write native provider config, store API keys separately through credential.create, refresh the selected location, and show the new models.
Extend the existing experimental global config patch to accept provider entries by ID without replacing other providers or JSONC comments. Config writes reload the owning config before returning. Regenerate the client.
How did you verify your code works?
bun run checkpassed.bun typecheck:e2eremains blocked by existing errors ine2e/performance/terminals/probe.tsande2e/performance/timeline/session-timeline-stream-probe.ts.Screenshots / recordings
No visual layout changes; the existing form now saves instead of showing an error. Covered by the browser regression.
Checklist