Repository navigation
fix(core): ignore directories named AGENTS.md during instruction discovery - #52576
Merged
Merged
Conversation
3 of 6 tasks
Ichinose-Kazuki
pushed a commit
to Ichinose-Kazuki/opencode
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #52301
Type of change
What does this PR do?
fs.upmatches any existing path, so bothAGENTS.mdwalks also picked up directories with that name (on macOS, any folder calledagents.md, e.g. a clone of a repo with that name):config/plugin/instruction.ts): reading the directory fails withEISDIR, the project source becomesInstructions.unavailable, and every prompt fails with "Instruction initialization blocked by unavailable sources: core/instructions".tool/plugin/read.ts): the directory makessessionInstructions.loadfail, and since that failure is swallowed, every nestedAGENTS.mdfrom that walk is silently dropped, including valid ones.fs.upgets an opt-intype: "file" | "directory"option. BothAGENTS.mdwalks passtype: "file", and the globalAGENTS.mdis skipped unless it is a regular file. Callers that legitimately match either kind (.git, which is a file in worktrees,.hg, project markers, config discovery) keep the default behaviour.A real
AGENTS.mdthat exists but can't be read still marks instructions unavailable, as before.How did you verify your code works?
--standalone) in a project inside$HOMEwith anAGENTS.mddirectory in its parent, a realAGENTS.mdabove that, anAGENTS.mddirectory insub/, and a real one insub/deeper/:v2: every prompt fails with the error above. With onlyread.tsonv2, readingsub/deeper/notes.txtloads no nested instructions.sub/deeper/AGENTS.md.fs.upwith notype,"file"and"directory"against a real directory tree.bun typecheckinpackages/utilandpackages/core; instruction, config, filesystem, git, project and read-tool tests inpackages/corepass.Screenshots / recordings
N/A
Checklist