Skip to content

fix(tui): hide permission tab indicators in auto mode - #52489

Closed
Max10240 wants to merge 4 commits into
anomalyco:devfrom
Max10240:v2
Closed

fix(tui): hide permission tab indicators in auto mode#52489
Max10240 wants to merge 4 commits into
anomalyco:devfrom
Max10240:v2

Conversation

@Max10240

@Max10240 Max10240 commented Oct 1, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #52486

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Hide permission ! markers on all session tabs when the client is in auto mode. Tabs previously checked only pending server requests, ignoring the client's permission mode.

Normal clients on the same server keep their indicators, and questions still show attention in both modes. This changes only tab display, not permission handling.

Background auto-approval is tracked separately in #44007; this PR does not fix it.

Add regression tests and update the affected test fixtures.

How did you verify your code works?

  • 55 focused TUI tests passed, including active/background tabs, normal/auto clients sharing events, and questions.
  • bun run check passed (warnings, no errors).
  • Built CLI, tmux: fresh clients opened two pending-permission tabs and a clean active tab on one server. npm 2.0.21 showed two ! markers with --auto; the fixed build showed none. Normal mode kept both, and both requests stayed pending.

Earlier full-suite runs had two dialog-shell-output timeouts; the full suite is not claimed to pass.

Screenshots / recordings

tmux tab-bar excerpts, with --auto and the same pending requests:

Before (npm 2.0.21):
! e2e-permission-one    ! e2e-permission-two    e2e-active-clean

After (built CLI):
  e2e-permission-one      e2e-permission-two    e2e-active-clean

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@Max10240 Max10240 mentioned this pull request Oct 1, 2026
Closed
3 of 6 tasks
@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:25
This was referenced Oct 28, 2026
Open
Open
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(tui): --auto shows permission attention on session tabs

2 participants

@Max10240 @max-10240