Repository navigation
fix(app): reuse one model tooltip when hovering between models - #52454
Closed
Sushants-Git wants to merge 1 commit into
Closed
Sushants-Git wants to merge 1 commit into
Sushants-Git wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50811
Type of change
What does this PR do?
Alternative approach to #50813, opened as a draft for comparison.
Instead of a tooltip per model row, the V2 model picker uses one
TooltipV2anchored to the hovered row. Moving between rows moves the same tooltip and swaps its content, so there is no remount, fade, or delay between items. Open state follows row hover, since Kobalte only reopens on pointer enter of the whole list.Only the model picker is changed.
anchorRefis passed through a spread because Kobalte forwards it to its popper at runtime but leaves it out of the Tooltip types.Can make it feel a bit more nice by adding a 120ms easing (not in this pr), vid below for that approach:
How did you verify your code works?
bun typecheckinpackages/app.Screenshots / recordings
Before (recording from #50813):
Screen.Recording.2026-09-22.at.11.39.22.PM.mov
Without easing:
Screen.Recording.2026-10-01.at.3.06.26.PM.mov
With easing:
Screen.Recording.2026-10-01.at.3.08.09.PM.mov
Checklist