Repository navigation
feat(app): play sound alert on question prompts - #52423
Closed
Harpocrator wants to merge 2 commits into
Closed
Harpocrator wants to merge 2 commits into
Harpocrator wants to merge 2 commits into
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Harpocrator
changed the title
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
When the agent pauses for user confirmation (
question.asked), no audible alert is played in the app, making it easy to miss that the agent is waiting.This PR makes two changes:
question.askedinpackages/app/src/pages/layout.tsx, reusing the existing permission audio settings.attention.enabledtotrueby default inpackages/tui/src/config/index.tsxso interactive prompts are audible out of the box in the TUI without needing manual configuration intui.json.How did you verify your code works?
Updated unit tests in
packages/tui/test/config.test.tsxandpackages/opencode/test/config/tui.test.tsto reflect the updated default configuration.Screenshots / recordings
N/A (audio/behavioral change)
Checklist