Repository navigation
fix(core): deliver live log events without persistence - #52090
vladislav-miroshnikov wants to merge 1 commit into
Conversation
|
@kitlangton, could you check the replay/live boundary here? Followers receive committed payloads directly, and subscription plus watermark capture use the aggregate commit lock. The regression includes a commit racing that capture with persistence off, which would otherwise be swallowed by the synced cursor. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Related to #42839, specifically the September 24 live-follow report. This does not add the CLI persistence option requested by the original issue.
Type of change
What does this PR do?
With persistence off, log followers wake and reread a table that contains no payloads. Send committed payloads directly to the aggregate's followers instead. Capture the subscription and watermark under the existing commit lock so a commit racing startup cannot be swallowed by the synced cursor.
History and restart retention stay unchanged. Active follower queues are unbounded, following the existing live channels; a stalled follower retains payloads until it catches up or closes.
How did you verify your code works?
The persistence-off and startup-race regressions fail before their respective fixes. Final local validation passes 57 Bus tests and the full core suite (5,553 passed, 31 skipped), package typecheck and root
bun run check.Screenshots / recordings
Not applicable.
Checklist