Repository navigation
fix: use basename for shell detection to support non-standard paths - #5205
Merged
Merged
Conversation
The shell exclusion check for fish and nu was hardcoded to specific paths (/bin/fish, /usr/bin/fish, etc.), which failed for users with shells installed in non-standard locations (e.g., /opt/homebrew/bin/fish, ~/.nix-profile/bin/nu). Now uses path.basename() to check just the shell name regardless of install path.
Collaborator
|
/review |
Contributor
|
lgtm |
Contributor
Author
|
Thanks for the review! |
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
…nomalyco#5205) Co-authored-by: Ayato French <[email protected]>
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…nomalyco#5205) Co-authored-by: Ayato French <[email protected]>
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
…nomalyco#5205) Co-authored-by: Ayato French <[email protected]>
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
…#5205) Co-authored-by: Ayato French <[email protected]>
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
…nomalyco#5205) Co-authored-by: Ayato French <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell exclusion check for fish and nu was hardcoded to specific paths (/bin/fish, /usr/bin/fish, etc.), which failed for users with shells installed in non-standard locations (e.g., /opt/homebrew/bin/fish, ~/.nix-profile/bin/nu).
Now uses path.basename() to check just the shell name regardless of install path.
Resolves: #5190