Repository navigation
fix(ai): guard Sonnet 5.5 Bedrock Converse requests - #52046
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Claude Sonnet 5.5 launched on September 28 with a Bedrock runtime Converse route. The existing Converse lowering could send forced tool choices, manual/disabled thinking, and non-default sampling, which the Anthropic migration guide says Sonnet 5.5 rejects. AWS's model card distinguishes runtime Converse from Mantle Messages (Mantle does not support Converse).
Type of change
What does this PR do?
http.bodyoverlays and return actionableInvalidRequesterrors for forced tool choice, unsupported thinking settings, and non-default sampling instead of silently relaxing user intent or passing known-invalid requests to AWS.between_toolsas a typed Sonnet 5.5 Bedrock thinking setting; don't append adaptive-thinking block binding when callers explicitly choose it. Guard its incompatible budget/binding/display and xhigh/max-effort combinations.How did you verify your code works?
bun typecheckinpackages/ai; scoped oxlint; Prettier;git diff --checkall pass.bun run checkreaches typecheck but cannot complete here: the host's Node 18 is unsupported by Astro in@opencode/posts. The affected package checks above pass.Screenshots / recordings
Not a UI change.
Requested by: @nexxeln (nexxel via Slack)