Repository navigation
fix: restore ability to bind keys for model_cycle_favorite model_cycle_favorite_reverse (resolves #5198) - #5202
Merged
rekram1-node merged 18 commits intoDec 15, 2025
Conversation
- Add model_cycle_favorite and model_cycle_favorite_reverse to Keybinds schema - Add TUI handlers for favorite model cycling - Add missing types to JS SDK KeybindsConfig - Both keybinds default to 'none' to maintain no new default keybindings - Total: 28 lines across 3 files Resolves anomalyco#5198
ariane-emory
marked this pull request as draft
December 9, 2025 00:53
ariane-emory
force-pushed
the
fix/allow-model-cycle-favorites-keybinds
branch
from
December 9, 2025 01:49
277b2aa to
b32a5d3
Compare
Restore the model_cycle_favorite and model_cycle_favorite_reverse keybindings that were accidentally removed from the UI configuration. These commands allow users to cycle through their favorite models with customizable keybinds. Changes: - Add model_cycle_favorite and model_cycle_favorite_reverse to Keybinds schema (default to 'none' to maintain no new default keybindings) - Restore UI command handlers for favorite model cycling in app.tsx - Regenerate SDK types to include the restored keybindings Resolves anomalyco#5198
ariane-emory
marked this pull request as ready for review
December 9, 2025 01:51
…e-favorites-keybinds
…e-favorites-keybinds
…e-favorites-keybinds
…e-favorites-keybinds
ariane-emory
marked this pull request as draft
December 10, 2025 23:30
Contributor
Author
|
Corrupted by a bad merge, will fix. |
ariane-emory
force-pushed
the
fix/allow-model-cycle-favorites-keybinds
branch
from
December 11, 2025 00:40
ae08dd6 to
2d7d73d
Compare
Contributor
Author
|
Fixed, uncorrupted. |
ariane-emory
marked this pull request as ready for review
December 11, 2025 00:47
shuv1337
added a commit
to shuv1337/shuvcode
that referenced
this pull request
Dec 11, 2025
…to bind keys for model_cycle_favorite model_cycle_favorite_reverse Resolved conflict: kept .github/workflows/sync-zed-extension.yml deleted (fork-specific)
ariane-emory
force-pushed
the
fix/allow-model-cycle-favorites-keybinds
branch
from
December 11, 2025 17:44
4d7b109 to
7200148
Compare
ariane-emory
marked this pull request as draft
December 13, 2025 00:50
ariane-emory
force-pushed
the
fix/allow-model-cycle-favorites-keybinds
branch
from
December 13, 2025 01:59
f843162 to
7200148
Compare
ariane-emory
marked this pull request as ready for review
December 13, 2025 02:00
ariane-emory
marked this pull request as draft
December 14, 2025 11:26
ariane-emory
marked this pull request as ready for review
December 14, 2025 11:27
- Keep manual changes to config.ts and app.tsx - Regenerate SDK types from OpenAPI spec instead of manual edits - Update OpenAPI spec from config schema This properly generates the model_cycle_favorite and model_cycle_favorite_reverse keybind definitions instead of manually editing generated files. Resolves the approach issue in PR anomalyco#5202 where generated files were being manually edited instead of being regenerated from the source schema.
Contributor
Author
|
@rekram1-node Whatcha thinking about this one? I'd love to be able to have some keys that would let me start actually enjoying @kcrommett 's wonderful work on the favourite models feature, and I'm sure I'm not the only one who'd like to be able to start enjoying his work. :) Just let me know if there's anything else I need to tidy up to make this PR mergable and I'll get straight to work on taking care of it... thanks! |
Collaborator
|
yeah should be good |
Contributor
Author
|
Fantastic, thanks very much! |
nalin-singh
pushed a commit
to nalin-singh/opencode
that referenced
this pull request
Dec 17, 2025
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
github-actions Bot
pushed a commit
to yuguorui/opencode
that referenced
this pull request
Jan 18, 2026
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
…e_favorite_reverse (resolves #5198) (#5202)
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
androidand
pushed a commit
to androidand/opencode-skein
that referenced
this pull request
Sep 19, 2026
…e_favorite_reverse (resolves anomalyco#5198) (anomalyco#5202)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to bind keys for @kcrommett's
model_cycle_favourite/model_cycle_favorite_reversecommands was seemingly lost in a commit that occurred a day after these commands were added.This PR restores the ability to bind these commands to keys.
No default keybinding is assigned, therefore:
opencode.jsonfiles.opencode.jsonfile.Resolves #5198.