Skip to content

fix(app): keep mobile question controls visible - #51771

Closed
ysm-dev wants to merge 1 commit into
anomalyco:devfrom
ysm-dev:mobile-question-scroll
Closed

fix(app): keep mobile question controls visible#51771
ysm-dev wants to merge 1 commit into
anomalyco:devfrom
ysm-dev:mobile-question-scroll

Conversation

@ysm-dev

@ysm-dev ysm-dev commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #51770

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Long questions and option lists can push Next and Submit off mobile screens. The height calculation falls back to the full viewport when there is no sticky timeline header, and the question text sits outside the scrollable area.

Measure the available session-panel height on mobile as well as desktop. Scroll the question text and options together, keeping the header and footer visible. Add a long-question story and mobile regression coverage.

How did you verify your code works?

  • bun run check passed in the new worktree.
  • Question component suite: 8 passed across Chromium and WebKit. Covers 393 × 852, 393 × 640, landscape, answer retention, submission, and desktop shortcuts.
  • Agent-browser: captured before/after screenshots, scrolled to option 12, advanced, and submitted answers. Also checked the production build with a local fixture server, viewport resizing, and RTL.
  • Production cold-session benchmark: 206.9 ms before, 214.2 ms after, one sample each. Two unrelated draft-entry assertions already failed on the baseline.

To reproduce locally: bun run test:components session-question-dock.spec.ts from packages/app, or open the LongQuestionRequest Storybook story at a mobile viewport.

Screenshots / recordings

Agent-browser captures of the production question component in the session story, at 393 × 852.

Before: Next is below the screen After: content scrolls, Next stays visible
Before: question options overflow and Next is not visible After: scrollable question content with a visible Next button
Long question scrolled to its options, with Back and Submit visible A long question scrolled to its options with Back and Submit visible

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@ysm-dev ysm-dev mentioned this pull request Sep 28, 2026
Closed
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@Bearmancer Bearmancer mentioned this pull request Sep 30, 2026
Closed
@opencode-agent opencode-agent Bot mentioned this pull request Oct 8, 2026
Closed
@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:20
@Ay7ot Ay7ot mentioned this pull request Oct 25, 2026
Open
1 task done
@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hona Hona Awaiting requested review from Hona
@Brendonovich Brendonovich Awaiting requested review from Brendonovich

Assignees

No one assigned

Labels

automated-pr-cleanup contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(app): question options and submit controls are cut off on mobile

1 participant

@ysm-dev