Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #50986
Type of change
What does this PR do?
Workspace user messages use the theme accent background, but paired it with a foreground meant for a different surface. One Dark Pro dark mode therefore rendered the message at about 1.1:1 contrast. I added an accent foreground token chosen against the resolved accent background and used it for the workspace message and mention prefix. This keeps the accent styling while choosing readable text for bright as well as dark accents. The selector and contrast diagnosis were documented in the issue discussion.
How did you verify your code works?
v2atde2cacd; upstream pending-message selectors and spacing remain intact.bun test src/theme/v2/resolve.test.tsinpackages/ui: 84 passed, 99 assertions, covering built-in color schemes, custom fallback and an overridden accent surface.git diff --checkpassed.bun run checkthrough the unmodified pre-push hook passed: full lint and SDK documentation checks, then 36/36 typecheck tasks. Astro diagnostics passed despite sandbox log-directory warnings.Screenshots / recordings
Before: Issue screenshot.
After, current code with One Dark Pro dark mode:
Checklist