Skip to content

fix(app): write provider visibility in one update - #51479

Closed
syyzit wants to merge 1 commit into
anomalyco:devfrom
syyzit:fix/provider-visibility-one-write
Closed

syyzit wants to merge 1 commit into
anomalyco:devfrom
syyzit:fix/provider-visibility-one-write

Conversation

@syyzit

@syyzit syyzit commented Sep 26, 2026 •

Copy link
Copy Markdown

Issue for this PR

Fixes #51480

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Toggling a provider in Manage models wrote one preference per model. On OpenRouter that is hundreds of writes, and the switch stalls.

This writes that provider's visibility once. Single-model switches are unchanged.

How did you verify your code works?

In the desktop app, Manage models, OpenRouter (384 models):

  • all on: 163 ms, 384/384
  • all off: 161 ms, 0/384
  • one model off: 18 ms, header off, 383/384
  • provider back on: 18 ms, 384/384

Google stayed 6/38.

Screenshots / recordings

None.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Toggling a provider updated every model separately and stalled on large catalogs.
@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Sep 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage models provider switch stalls on large catalogs

1 participant