Repository navigation
fix(desktop): preserve selected directories and propose local connection links - #51431
Closed
marcusquinn wants to merge 3 commits into
Closed
marcusquinn wants to merge 3 commits into
marcusquinn wants to merge 3 commits into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51430 (connection-link design proposal). Fixes #50821 (explicit directory selection). Related: #29869, #43316.
Type of change
What does this PR do?
Preserves explicitly opened directories instead of replacing them with the primary path of a shared Git project. Canonical checkouts and linked worktrees remain independently selectable.
A separate commit proposes a confirmed, loopback-only
opencode://connectflow and packaged capability discovery for launchers. It preserves saved defaults and credentials, supports cold launches, and opens a draft in the requested directory. Draft pending core-team design review of this new UI/interface. The directory fix is separable as commit131840bb94.How did you verify your code works?
Six Chromium regressions pass: add/reload/close/reopen/exact draft directory with either Git primary, existing picker search, connection cancellation, and cold-start confirmation. App, Desktop and E2E typechecks pass; 42 scoped app tests and 9 Desktop tests pass. No live databases were migrated.
Reproduce from
packages/app:PLAYWRIGHT_PORT=4484 PLAYWRIGHT_SERVER_PORT=4485 PLAYWRIGHT_WORKERS=1 bun run test:e2e e2e/regression/connection-links.spec.ts e2e/regression/project-directory-selection.spec.ts e2e/regression/project-picker-recent-search.spec.ts --project=chromium.Screenshots / recordings
Captured by the Chromium regressions above (desktop width; also checked locally at 390px mobile width with no page errors).
Connection confirmation — shown before any health request; Cancel changes nothing:
Explicit directories — a canonical checkout and a linked worktree of the same Git project stay separately listed and selectable:
Packaged Electron end-to-end acceptance remains unverified.
Checklist
aidevops.sh v3.37.1 plugin for OpenCode v2.0.3 with claude-opus-5-5 spent 13m and 6,518 tokens on this with the user in an interactive session.