Repository navigation
fix(ai): fit OpenRouter reasoning budgets to the output limit - #51189
Merged
Merged
Conversation
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A. Found while testing default output limits for #51021.
Type of change
What does this PR do?
OpenRouter now fits
reasoning.max_tokensto half the output limit withProviderShared.fitThinkingBudget, the same rule the other protocols got in #51157.OpenRouter forwards
reasoning.max_tokensas the upstream thinking budget, but its body builder copied thereasoningoption through unchanged. Upstreams such as Alibaba and Anthropic reject a budget that is not below the output limit. OpenRouter's Qwenmaxvariant sends a 131,071 budget, so a 32k compaction summary failed:reasoning, and requests without an output limit.How did you verify your code works?
openrouter/qwen/qwen3.8-flashmax:max_completion_tokens: 131072,reasoning.max_tokens: 65536.max_completion_tokens: 32000,reasoning.max_tokens: 16000. The summary completed, where it was rejected before.Screenshots / recordings
N/A
Checklist