Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
3 tasks done
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51179
Type of change
What does this PR do?
EffectFlock.acquirestarted its heartbeat withfs.utimes(path, new Date(), new Date())piped intoEffect.repeat. The repeat reruns that same effect, so both dates stay at the time the lock was acquired and the heartbeat never moves forward. Once a lock has been held for 60 s,isStaletreats it as abandoned, and another process can break it while the holder is still working, for example during a slow npm install or a repository clone.Wrapping the call in
Effect.suspendbuilds a newutimeseffect on each tick, so each tick writes the current time. The rest of the heartbeat fiber is unchanged: same schedule, still scoped to the lock and interrupted before release.How did you verify your code works?
New test in
packages/core/test/util/effect-flock.test.ts: acquire a lock, backdate its heartbeat by 120 s, wait 1 s of wall time, advance the TestClock by one heartbeat interval, then check the heartbeat's age. Before the fix it fails (age 1058 ms, the acquisition time); after it, it passes.bun test test/util/effect-flock.test.tspasses (12 pass, 0 fail) andbun typecheckis clean inpackages/core.Screenshots / recordings
n/a
Checklist