Repository navigation
fix(core): cap Alibaba thinking budget variants at 64k - #51154
Merged
Merged
Conversation
rekram1-node
force-pushed
the
qwen-thinking-variants
branch
from
September 24, 2026 17:42
8e4be5a to
96656f8
Compare
rekram1-node
force-pushed
the
qwen-thinking-variants
branch
from
September 24, 2026 18:13
0013a22 to
3b09d8f
Compare
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A. Found while testing default output limits for #51021.
Type of change
What does this PR do?
Alibaba thinking budget variants now stop at 64k. Anthropic's already stop at 32k.
models.dev lists
budget_tokenssupport for these models without a maximum, sovariant.tsderived the budgets from the catalog output limit:maxwas the output limit minus one, andhighwas half of it.high/max)qwen3.7-plus,qwen3.7-maxalibaba/*models.maxbudget of 131,071 against 131,072 cut the answer off after 8 tokens, and Alibaba rejected the 32k summary ("max_completion_tokens [32000] must be greater than thinking_budget [131071]").maxof 262,143 was above the 256k default output limit in feat(core): fit output limits to the context window #51021.How did you verify your code works?
packages/corevariant and models-dev suites pass.qwen3.7-plusmaxon Alibaba completed a title, tool steps, and a compaction summary. See fix(ai): fit thinking budgets to the output limit #51157 for the request fields.Screenshots / recordings
N/A
Checklist