Repository navigation
fix(core): send Grok reasoning effort on Bedrock Converse - #51151
Merged
Merged
Conversation
4 of 6 tasks
rekram1-node
force-pushed
the
qwen-budget-variants
branch
from
September 24, 2026 15:41
adbf30a to
e7a3bde
Compare
rekram1-node
force-pushed
the
qwen-budget-variants
branch
from
September 24, 2026 15:56
e7a3bde to
1f82b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A. Found while testing default output limits for #51021.
Type of change
What does this PR do?
Grok 4.6's reasoning effort variants on Bedrock Converse (
us.xai.grok-4.6,global.xai.grok-4.6) now send the field Bedrock actually reads.They used to fall into the generic branch of
variant.tsand send Nova'sadditionalModelRequestFields.reasoningConfig.maxReasoningEffort. Bedrock silently ignores unknown fields for Grok, so every request ran at Grok's default effort (lowon Bedrock).They now send
additionalModelRequestFields.reasoning.effort, the same shape we already use for OpenAI models on Bedrock. AWS's Grok 4.6 model card documents effort through thereasoningparameter.How I confirmed the field: I sent an invalid effort through each candidate field. Only a field Bedrock reads rejects it.
"bogus"effortreasoning: { effort }reasoning_effortreasoningConfig.maxReasoningEffort(before)Other Grok routes: xAI direct and Bedrock Mantle already use the Responses API with
reasoning.effort, and Mantle rejects an invalid effort the same way.Nova 2: still gets
reasoningConfig.How did you verify your code works?
packages/corevariant and models-dev suites pass.additionalModelRequestFields.reasoning.effortatxhighandlow, and both returned 200.Screenshots / recordings
N/A
Checklist