Skip to content

fix(core): send Grok reasoning effort on Bedrock Converse - #51151

Merged
rekram1-node merged 1 commit into
v2from
qwen-budget-variants
Sep 24, 2026
Merged

rekram1-node merged 1 commit into
v2from
qwen-budget-variants

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Issue for this PR

N/A. Found while testing default output limits for #51021.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Grok 4.6's reasoning effort variants on Bedrock Converse (us.xai.grok-4.6, global.xai.grok-4.6) now send the field Bedrock actually reads.

They used to fall into the generic branch of variant.ts and send Nova's additionalModelRequestFields.reasoningConfig.maxReasoningEffort. Bedrock silently ignores unknown fields for Grok, so every request ran at Grok's default effort (low on Bedrock).

They now send additionalModelRequestFields.reasoning.effort, the same shape we already use for OpenAI models on Bedrock. AWS's Grok 4.6 model card documents effort through the reasoning parameter.

  • How I confirmed the field: I sent an invalid effort through each candidate field. Only a field Bedrock reads rejects it.

    Field "bogus" effort
    reasoning: { effort } 400: "Supported values are: 'none', 'low', 'medium', 'high', 'xhigh', and 'max'"
    reasoning_effort 200 (ignored)
    reasoningConfig.maxReasoningEffort (before) 200 (ignored)
  • Other Grok routes: xAI direct and Bedrock Mantle already use the Responses API with reasoning.effort, and Mantle rejects an invalid effort the same way.

  • Nova 2: still gets reasoningConfig.

How did you verify your code works?

  • Unit test: covers Bedrock Converse effort variants for Grok 4.6 and Nova 2. The packages/core variant and models-dev suites pass.
  • Live against Bedrock: Grok 4.6 through this branch sent additionalModelRequestFields.reasoning.effort at xhigh and low, and both returned 200.

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@rekram1-node rekram1-node changed the title fix(core): skip thinking budget variants for Qwen models fix(core): correct Qwen and Bedrock Grok reasoning variants Sep 24, 2026
@rekram1-node rekram1-node changed the title fix(core): correct Qwen and Bedrock Grok reasoning variants fix(core): send Grok reasoning effort on Bedrock Converse Sep 24, 2026
@rekram1-node
rekram1-node merged commit 0e4ad0c into v2 Sep 24, 2026
10 checks passed
@rekram1-node
rekram1-node deleted the qwen-budget-variants branch September 24, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant