Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
f8e8294 to
fcf3153
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #49216
Type of change
What does this PR do?
Pressing ctrl+b while a foreground subagent (or shell) runs did nothing, even though the hint advertised the shortcut.
session.backgroundis registered twice: once by the prompt and once by the session route. The prompt copy guards on the autocomplete and input focus with a barereturn, which stops the keymap command chain — theKeymapCommand.runcontract is "return false to continue" — so the session route's unconditional command never ran and the keypress was silently dropped.The prompt guards now return
false, so the chain falls through to the session route's command and the action runs.How did you verify your code works?
Added
packages/tui/test/cli/tui/session-background.test.tsx: ctrl+b dispatchessession.backgroundwhile a textarea is focused (the default also overlapsinput.move.left, but the later session layer wins, so the overlap is not the failure), a guard returning false falls through to the earlier layer, and a disabled duplicate does not block the earlier layer. Ranbun testandbun typecheckinpackages/tui.Screenshots / recordings
N/A — keybind behavior, no visual change.
Checklist