Skip to content

fix(tui): let session.background fall through to the session layer - #51070

Closed
Veld101 wants to merge 1 commit into
anomalyco:devfrom
Veld101:tui-background-fallthrough
Closed

Veld101 wants to merge 1 commit into
anomalyco:devfrom
Veld101:tui-background-fallthrough

Conversation

@Veld101

@Veld101 Veld101 commented Sep 24, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #49216

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Pressing ctrl+b while a foreground subagent (or shell) runs did nothing, even though the hint advertised the shortcut.

session.background is registered twice: once by the prompt and once by the session route. The prompt copy guards on the autocomplete and input focus with a bare return, which stops the keymap command chain — the KeymapCommand.run contract is "return false to continue" — so the session route's unconditional command never ran and the keypress was silently dropped.

The prompt guards now return false, so the chain falls through to the session route's command and the action runs.

How did you verify your code works?

Added packages/tui/test/cli/tui/session-background.test.tsx: ctrl+b dispatches session.background while a textarea is focused (the default also overlaps input.move.left, but the later session layer wins, so the overlap is not the failure), a guard returning false falls through to the earlier layer, and a disabled duplicate does not block the earlier layer. Ran bun test and bun typecheck in packages/tui.

Screenshots / recordings

N/A — keybind behavior, no visual change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@Veld101
Veld101 force-pushed the tui-background-fallthrough branch from f8e8294 to fcf3153 Compare October 12, 2026 14:30
@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tui: ctrl+b background hint shown but keypress does nothing

1 participant