Repository navigation
fix(ci): apply the PR body issue fallback on the default branch copy - #51058
Tsuki-hash wants to merge 1 commit into
Conversation
|
The following comment was made by an LLM, it may be inaccurate: |
|
One gap this change does not close by itself, in case it is worth handling here. The job only triggers on A |
|
Correct, and thanks for the per-PR table in #51057 - it is the first independent confirmation of this, with 8 data points instead of my 2. On handling the backfill here: I would rather not. A |
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
Issue for this PR
Fixes #51057 (#51057)
Type of change
What does this PR do?
#43964 taught
pr-standardsto fall back to the PR description, becauseclosingIssuesReferencesisonly populated when a PR targets the default branch. That change landed on
v2and never reacheddev,and
pull_request_targetruns the default branch's copy of the workflow — so the fallback exists in thetree that ships and is dead in the copy that executes. The job log of #51052 is the proof: its
check-standardsscript containsif (linkedIssues === 0)and nohasBodyIssueRef.This copies those same nine lines into dev's file. No other behavior changes; PRs against
devareunaffected in practice because they already get a real closing reference.
Disclosure: two of the mislabeled PRs are mine (#51038, #51052), so merging this removes a label from my
own work. #51035 and #51043 are other people's and carry the same label for the same reason.
How did you verify your code works?
check-standardsgithub-scriptbody from each, and compared: after this change the dev copy's script is identical to the v2 copy's.node --check, so the insertion cannot break the embedded JS, and it sits inside the existingscript: |block at the same indentation, so the YAML structure is unchanged (both jobs still parse).closingIssuesReferences.totalCountthe API returns for it today (all four are 0): all four evaluate as "issue referenced", i.e.needs:issuewould be removed instead of added.dev) reportsclosingIssuesReferences = [51057]and carries no label, while fix(server): resolve the configured shell for session terminals #51052 (basev2, same author, same template) reports 0 and was labeled. Same account, same hour, only the base branch differs.devafter merge is still the missing confirmation.Screenshots / recordings
No UI change.
Checklist
"Tested locally" is the file/script comparison, the syntax check and the regex replay above; the workflow itself was not executed.