Repository navigation
fix(app): close tabs of sessions deleted elsewhere, as in the TUI - #51044
Closed
opencode-agent[bot] wants to merge 3 commits into
Closed
opencode-agent[bot] wants to merge 3 commits into
opencode-agent[bot] wants to merge 3 commits into
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
September 24, 2026 05:51
3 of 6 tasks
opencode-agent
Bot
force-pushed
the
web-delete-test
branch
from
October 6, 2026 09:57
a018475 to
1c3d3f3
Compare
opencode-agent
Bot
changed the title
1 task done
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match the TUI's handling of a session deleted outside this window (
packages/tui/src/context/session-tabs.tsx,packages/tui/src/app.tsx):Session "<title>" was deletedonly when the deleted session was being viewed. Background tabs close silently.session.deletedevent identifies them.removeSessionspreviously matched the current route only against a tab's root session.Checks
bun typecheckinpackages/app: passed.No production deployment.
Requested by: @Brendonovich (Brendan via Slack)